Micha Reiser

Results 735 comments of Micha Reiser
trafficstars

@zoidbergwill can you confirm the libc version installed on your system by pasting the result of the following two commands ```bash ldd --version yum list glibc ``` [source](https://www.liquidweb.com/kb/how-to-check-the-glibc-gnu-libc-version-on-centos-6-and-centos-7/)

One option is to use the same docker container that Rust uses to build. https://github.com/rust-lang/rust/tree/master/src/ci/docker

> How would this work with Visual Studio Code? Sorry, my explanation was a bit brief. The idea is to use use the docker container in the CI pipeline that...

> I managed to build and run rome using https://quay.io/repository/pypa/manylinux2014_x86_64 (glibc 2.17) This is my suggestion, instead of supporting musl. We may still want to consider a `musl` build for...

The two are related but require slightly different solutions Supporting musl requires a separate Rome build for every platform that links against musl instead of glibc. Musl is a Tier...

> Would it also be possible for it to read `.prettierignore`, or are the ignore formats not compatible? That should be possible once our ignore setting supports negative patterns.

> `rome check` can also parse JSX inside a JS file, is there any flag or config we should add to the CLI to make it fail? There's no such...

@leops I remember we once discussed whether this is something that should be implemented in the formatter or as a lint rule due to its unsafe nature. Do you remember...

> IMO this should be a linting rule with auto fix. I never heard about import ordering at formatter level… Sorting imports is a tricky one, and I can see...

While the suggestion isn't ideal I would say that it is correct. Does Rome recommend to simplify `if·(!(a·&&·b·)·||·!c)·{` after you applied the fix? That's why I mark this as an...