Joshua Rogers

How about the other way around?

Note: I didn't test this thouroughly, but I will leave some comments for things that must be addressed be before merging.

> I think it might be good to be explicit that the contents of MSR_IA32_FEATURE_CONTROL need to be restored in resume (I think that's what "MSR lock" is referring to?)...

> > Note: any IOMMU context will remain lost for any enabled vmm devices. > > Even if this isn't a new issue from your change, should we have this...

>Is there an actual bug being fixed here Yes. A couple of things: 1. `-P=password` and `--password=password` (and etc.) were not redacted previously, 2. `-P 'abc def'` would only redact...

Sure, I've added some tests.

Note this introduces a vulnerability in systems which use a proxy in front of the server. If your fiber server is behind a proxy, and the proxy disallows access to...

Understood, thanks. It would be nice to add that information to the documentation.

There is a problem remaining with the patch. `vm_manager()` calls `destroy_vm()` always after bhyvectl is started, and possibly `destroy_nmdm()` and `destroy_bridge()` The "problem" is that `vm_stop()` also calls `destroy_vm()` unconditionally,...

>For `destroy_bridge()`, what worked for me is to remove its invocation from `vm_manager()`, right before calling `quit_daemonization()`. Just to confirm: are you satisfied that there is no condition that the...