osx-sign icon indicating copy to clipboard operation
osx-sign copied to clipboard

redact passwords from logs correcrtly

Open MegaManSec opened this issue 5 months ago • 1 comments
trafficstars

also return an opts if possible.

MegaManSec avatar May 30 '25 17:05 MegaManSec

Is there an actual bug being fixed here

Yes. A couple of things:

  1. -P=password and --password=password (and etc.) were not redacted previously,
  2. -P 'abc def' would only redact abc.
  3. -P abc -P def would only redact abc -- of course, this is user error, but I thought why not patch it anyways.

MegaManSec avatar May 31 '25 14:05 MegaManSec

Sure, I've added some tests.

MegaManSec avatar Jul 15 '25 14:07 MegaManSec