Matthias Kainer

Results 14 comments of Matthias Kainer

> Have not reviewed thoroughly, but would this change allow something like the Cypress wrapper to put cy.get() as the querySelectorAll implementation, allowing hooking into the base retry methods? I...

@eps1lon I was thinking about this quite a bit, and looking at the test adjustments needed by directly including a query mechanism for shadow dom let me to the conclusion...

Created docs here: https://github.com/testing-library/testing-library-docs/pull/964 ~~Broke the git history, will clean that up next~~ /edit: fixed

@eps1lon do you need anything else to move this forward?

@surfer19 Yes, react-testing-tools is only a wrapper around the dom-testing-tools (see https://github.com/testing-library/react-testing-library/blob/main/src/pure.js#L119). Integrating a react app with react-testing-tools with a stenciljs design system (with shadow dom) is the original usecase...

@surfer19 jop, if you use [query-selector-shadow-dom](https://github.com/Georgegriff/query-selector-shadow-dom) as shown in the description it will reach into arbitrary deep shadow doms. If this request is merged I would also use the opportunity...

Are there any updates? Is there something else I should add?

I just merged the latest changes main, and the build fails. I will fix this and try again

okay, I tried to follow codesandbox to the letter, including installing the same node version ``` ❯ git clone https://github.com/testing-library/dom-testing-library.git Cloning into 'dom-testing-library'... remote: Enumerating objects: 3523, done. remote: Counting...