Jongsun Suh

Following up on the last bullet point in the above comment, the [wallet framework proposal also suggests](https://github.com/MetaMask/core/pull/4105/files#r1538174024) refactoring the `ComposableController` into a `compose` function that returns a class instance that...

Priority analysis: - If ComposableController is only used internally: Nice-to-have. - If ComposableController is included in the Wallet Framework: Should at least aim for partial improvements.

There were some [recent type changes in `@metamask/json-rpc-engine`](https://github.com/MetaMask/core/compare/@metamask/[email protected]...@metamask/[email protected]#diff-07a20aba14734ed38b0fbb7950cc14249fa7b9f836236734edef2001fb16359e) that may have affected error handling behavior, although the intention was to avoid introducing runtime breaking changes. Looking at the `_promiseHandle` method...

I was able to fix the implicit `any` issue by cherry-picking https://github.com/MetaMask/metamask-extension/pull/26551. All resulting type errors are resolved with these changes: ```diff diff --git a/app/scripts/lib/rpc-method-middleware/handlers/send-metadata.ts b/app/scripts/lib/rpc-method-middleware/handlers/send-metadata.ts index a6b4cec847..5bec59b57a 100644 ---...

@metamaskbot update-policies

Leaving this here as a placeholder for upcoming PR comments. ```diff diff --git a/app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.ts b/app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.ts index f179898d38..4fbbeb729c 100644 --- a/app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.ts +++ b/app/scripts/lib/rpc-method-middleware/handlers/add-ethereum-chain.ts @@ -8,17 +8,15 @@ import type { PendingJsonRpcResponse,...

My bad, I left that line incomplete. Thanks for pointing that out. `validParams` is evaluating to an implicit `any`, so we need to fix the return type of `validateAddEthereumChainParams`. To...