Jongsun Suh

The attached PR (#3912) records an initial approach discussed by the team during refinement. The ticket is available for anyone to take over and build on top of (or discard)...

- Completing this ticket will enable us to take full advantage of the type safety improvements that will be introduced by the [provider alignment technical proposals](https://app.zenhub.com/workspaces/shared-libraries-621e46b4d7103800171d1b02/issues/zh/244). - All of the...

- See previous refactor efforts: https://github.com/MetaMask/json-rpc-engine/pulls?q=is%3Apr+is%3Aopen+sort%3Aupdated-desc - Especially relevant: https://github.com/MetaMask/json-rpc-engine/pull/84

The `any` usage here occurs in the `send` and `sendAsync` methods of the `SafeEventEmitterProvider` class. Both methods are slated to be deprecated but not removed by this proposal ([Align provider...

This can probably wait until the provider alignment proposal moves forward, and we can be certain that `send`/`sendAsync` will be sunsetted as legacy methods.

One approach we could take is to add the types listed in requirements as generic parameters to the ComposableController class and compute them in place: ```ts export class ComposableController< ChildControllers...

In other packages we've been using `"^18.18 || >=20"` instead of `">=18.18 || >=20"` in the `engines` field and yarn constraints. Are we purposefully going for a stronger constraint in...

Merging `TokenDetectionController` with `DetectTokensController` has introduced new behaviors and branches. These are some new tests that will need to be added: - Correctly responds to `KeyringController:lock`, `KeyringController:unlock`, `AccountsController:selectedAccountChange`, `PreferencesController:stateChange` events....

The scope of this ticket no longer includes the API changes caused by the consolidation with `DetectTokensController`. However, it needs to update the tests in the extension [`detect-tokens.test.js`](https://github.com/MetaMask/metamask-extension/blob/68cc610976485d0071400cb2d4c3ea18cc6b15d9/app/scripts/controllers/detect-tokens.test.js) file to...

- https://github.com/MetaMask/core/issues/3661 is fixed by https://github.com/MetaMask/core/pull/3938 (https://github.com/MetaMask/core/pull/3938/commits/f060ced256d24ce5069873e44686cd5d152960d0), but no unit tests were written for this behavior change. - We should write these tests in this ticket.