Scott Mabin

Results 343 comments of Scott Mabin
trafficstars

One reference for the peripherals is the list @SergioGasquez created here: https://github.com/esp-rs/esp-hal/issues/809#issuecomment-1999308797

Closed via https://github.com/esp-rs/esp-hal/pull/3011

I like this idea in general, but I'd like to see the design fleshed out a little more before we commit to it. Just some loose thoughts: * Does it...

I think the benefits of `into_async` are clear, and IMO we should move forward with this to avoid exponential amounts of constructors on some drivers. I'm not yet convinced about...

With #2430 & the follow up with https://github.com/esp-rs/esp-hal/pull/2461, the only remaining drivers with `new_async` are the low level timers. This begs the question, should the low-level timers (TIMG & Systimer)...

I'm leaning towards removing the impls on the timers, and therefore the mode parameters too, and only implemented the eh/eha traits on the top level timer driver objects. I'll let...

> I'm leaning towards removing the impls on the timers, and therefore the mode parameters too, and only implemented the eh/eha traits on the top level timer driver objects. Let's...

The last two remaining `new_async` methods have been removed :rocket:

Do we know if an exception is raised whilst accessing atomics in psram, or does it just silently fail? If we can detect it, that at the very least opens...

I'll try and find those answers and get back to you. In the meantime, the only truly bullet-proof way to solve this right now is to have a target variant...