Luca Palmieri
Luca Palmieri
You need to pass the `--bin` option to both `cargo-chef` commands, just as you are doing for your `cargo build`.
It's expected that it takes a comparable amount of time if you're starting without a cache. With a cache hit, those 3 minutes disappear.
> it's a bit faster with the S3 cache - but even with no code changes the build step still compiles quite a lot of dependencies - I was expecting...
Understanding why that is the case would require a reproducible example for me to analyse.
We should be careful here with respect to when concepts are introduced—we have no knowledge of conversion traits at this stage, so we can't give a precise explanation as to...
I've rebased on the latest `master`. Can you give it a final look @kei-nan?
Let's split this PR in 3 smaller ones: 1. `varint`and `VectorWriter` pure Rust implementations, with docs, tests and microbenchmarks 2. `Buffer`. Let's add tests and document our safety invariants, following...
Correct, closing. Thanks for raising it!
Thanks for the PR! For now we'll stick to the existing styling though.
The implementation looks good! Can you add a UI test for it? You can use [this one](https://github.com/LukeMathWalker/pavex/tree/main/libs/ui_tests/blueprint/constructors/a_warning_is_emitted_for_unused_constructors) as a reference. The test should live [in this folder](https://github.com/LukeMathWalker/pavex/tree/main/libs/ui_tests/blueprint/common).