100-exercises-to-learn-rust icon indicating copy to clipboard operation
100-exercises-to-learn-rust copied to clipboard

Re-order actions you can take with a Result

Open illicitonion opened this issue 1 year ago • 3 comments

It's generally better practice to handle or propagate errors, rather than panicking in response to them. This edit moves panicking to be the last option introduced, rather than the first. It also adds caveats to avoid doing so, and explicitly mentions propagating as something to consider.

illicitonion avatar Oct 31 '24 13:10 illicitonion

Deploy Preview for taupe-lily-3539f6 ready!

Name Link
Latest commit 2e2f6b945dece8e6b3706f50722fa1774aa17944
Latest deploy log https://app.netlify.com/sites/taupe-lily-3539f6/deploys/67238ad3f2757d0008ee3617
Deploy Preview https://deploy-preview-201--taupe-lily-3539f6.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Oct 31 '24 13:10 netlify[bot]

@illicitonion Thanks for your contribution! I think it's a good addition overall. However, the story about the ?-operator is a bit more complicated, as it will do a conversion as well if possible and necessary. Can you update your text so that it covers that part as well?

hdoordt avatar Jan 27 '25 13:01 hdoordt

We should be careful here with respect to when concepts are introduced—we have no knowledge of conversion traits at this stage, so we can't give a precise explanation as to how ? actually behaves.

My suggestion is to remove ? from this bullet list, make it its own sub-section in the same chapter and clarify in a footnote that there's more to this that'll be discussed later, with a link to the chapter where we do. That chapter's text also needs to be adjusted to reflect the fact that ? has already been introduced.

LukeMathWalker avatar Jan 28 '25 11:01 LukeMathWalker