linkgoron
linkgoron
This also reproduces on my local machine (macOS Catalina)
I assume that it's a similar issue to https://github.com/nodejs/node/pull/36871. There's a timeout issue that's getting emitted on the request in `_test-double-benchmarker`. A simple workaround that worked locally for me was...
Just to clarify what I've stated earlier - at least locally, for me, I see similar issues with the http-server benchmark in the `async_hooks` benchmarks. There are two issues here...
maybe `onRedirect` should be able to "short-circuit" the redirection (e.g. by returning `false`)?
> We need a way to control the security of this. There are quite a few possible attacks when reading files from disk on servers. > > My opinion is...
> > This kind of change would make this less portable (which was one of the reasons why this was requested), as I assume that other implementation don't have such...
> While it's not a web option, could we just have an option to `fetch` to allow file urls? Browsers would simply ignore such an option so it would still...
Should this be semver-major, as this could easily cause crashes to apparently working programs? if Node already handles non-string values in a somewhat sane fashion, maybe the docs need to...
I've added two extra changes. They're technically not from lib-storage, but I felt that they're of the same spirit as my other changes so I thought that it made sense...
@AllanZhengYP Hi, I'm pinging you because you've also replied in my other PR. Is there anything that I need to do to get this PR rolling (am I missing something,...