Lin Zhihao comments

Results 14 comments of


                                            Lin Zhihao

IntelliSense does not respect C++ standard on MacOS

I have seen the same issue. Is there any way I can turn this error off?

Implement StreamingReader as a ReaderInterface to directly stream data from a valid URL.

Made a few changes to make the code more maintainable: 1. wrap curl using C++ classes to provide better error handling and cleaner object lifetime management 2. using `clp::Thread` to...

Implement StreamingReader as a ReaderInterface to directly stream data from a valid URL.

> Do you consider moving curl-related functions and classes into a separate file? I think for now we don't have to since this is the only file using the curl-related...

Implement StreamingReader as a ReaderInterface to directly stream data from a valid URL.

> How about: > > core: Add NetworkReader to stream data from a URL. (#278) Uisng `core: Add NetworkReader to stream data from a URL using libcurl.` instead to indicate...

core-clp: Rewrite wildcard matching method and add systematic unit tests (fixes #427).

> > 1. The generation of the wild and tame is deterministic. Can we pre-generate them and add a script used for generation? Or we don't really care about the...

clp: Add support for SQLite prepared select statement.

The refactoring lgtm

core-clp: Refactor `LibarchiveFileReader` to properly handle empty data blocks (fixes #389).

> A high level comment: Methodlogy wise, I feel the rest of our code tend to let caller check if the data_block is empty, rather having a function to read...

core-clp: Refactor `LibarchiveFileReader` to properly handle empty data blocks (fixes #389).

> > Anyway, it's my personal preference and I will let you decide. > > Remind me, Zhihao, did we reach a conclusion on this? > > Also, can you...

clp: Infinite loop when compressing zip archive.

The bug can be reproduced by compressing the following empty archive using `clp`: [emptyFile.zip](https://github.com/user-attachments/files/15920365/emptyFile.zip)

core: Add unit test for LogEventSerializer

Before adding review comments, I think it's worth discussing the high-level concern here. The changes in `decoding_methods.hpp/cpp` should be moved to another PR for the following reasons: 1. The code...