Cristian Le

Results 775 comments of Cristian Le
trafficstars

@henryiii what do you think, should we make a function `in_distro` or such to detect rpm/deb environments and set the default build type accordingly? For reference the [`%cmake` macro](https://src.fedoraproject.org/rpms/cmake/blob/rawhide/f/macros.cmake.in) that...

> fedora could export an environment variable, that would work. Don't know if it's possible, though? That would be my preference as well, but it is a tricky one. @hroncok...

> but also largely the project being importable to extract type hints I could use a reference for this to understand. I thought this is still left to the predefined...

Yeah, I am looking now if there is any tool that can read the `dist-info` and re-package the wheel. All of the data seems to be in there to be...

When building the `.spec` file, there is no network connection, so I wouldn't be able to download them, and that would also not cover the version difference between PyPI and...

But there are other tests like: https://github.com/scikit-build/scikit-build-core/blob/eb578176d44c6ad0b54164d6f49498a99e30933c/tests/test_editable.py#L28 These use `isolate` -> `pep518_wheelhouse`, and are automatically marked as `network`. Probably we can refine those fixtures to combine it with the `isolate`...

Not PyPI specifically, but [`cibuildwheel`](https://github.com/pypa/cibuildwheel) is part of pypa. The most important thing that it does is match the compiler and libc used to the wheel tags so that the...

Also for header-only packages, it is arch-independent, so it should be sufficient to just install the project like normal with ```toml [tool.scikit-build] wheel.platlib = false ``` At which point you...

Just a quick comment, please use https://test.pypi.org/ for testing uploads. Otherwise you would be reserving the package name publicly. Other than that congrats on getting your setup in place. You...

Welcome to one of the "funnest" aspects of packaging: making shared libraries compatible. Windows in particular is quite a work of art. Before doing anything I would recommend to first...