Cristian Le

Results 807 comments of Cristian Le
trafficstars

From my reading of the original post I think it's more on the `conda` side of `ninja`?

Could you re-run it with verbose options? Maybe even debug logging: ```console pip install . -v --config-settings=cmake.verbose=true --config-settings=logging.level=DEBUG ```

Thanks for clarifying the blocking feature. I am not sure I understand what is meant with `run_setup(true/false)`. Is it to disable the cmake build part? Can you walk me through...

> I don't believe 2) can be implemented using scikit-build-core so far. Couldn't this be controlled within CMake, e.g. adding an advanced option `ALLOW_FALLBACK` (normally I insist projects to add...

> In this case I still want the fallback version to be installed Aaah, now I understood. Wow that's a tricky set of conditions to support. Kudos for the extra...

> I install the Python and C implementations side by side and import the fastest version available. Interesting, it's different to my situation when I want to link to either...

No clue from my side. To me `if.system-cmake` reads like "did we use the cmake from system". Maybe `if.cmake-vendor` can be a more general form of that, although `vendor` sounds...

To me `if.(no-)system-cmake` reads more like it would be a `bool` and would evaluate to `(true)false` when a wheel is used. `if.have-cmake` would be more explicit of no system cmake...

Yes, `nlohmann_json_schema_validator::validator` is correct and it will work with either `find_package` or `add_subdirectory`. Sorry I did not get to updating the README. One thing I haven't implemented is a consistency...

Finally setup my desk I can have a look at it. Did you manually set an environment varialbe `nlohmann_json_VERSION` or did you `add_subdirectory` (or `FetchContent`) for `nlohmann_json`? I think there's...