Cristian Le

Results 920 comments of Cristian Le
trafficstars

A few crucial ones are `preset`, `trace` and `debug-find`. The latter two are for debugging and internal use for `scikit-build-core`, so it should be custom handled. And `preset` is a...

I don't quite follow how this doesn't work with having `wheel.packages` be a list. Can you clarify how the `site_packages` folder is meant to be after the install, and where...

Ohh, now I understand. Quite unintuitive to navigate, and I am not sure if tools like `pytest-cov` can handle such structure, but in principle it should be doable. Are there...

Oh wow, that's quite a neat implementation, thanks for the reference. I will be borrowing that design

Try `find_package(Python3)` (instead of `find_package(Python)`) just in case. Edit: Oh I looked at your PR and you have it. Why do you include the `3.8` though? I see that the...

> As for the `3.8`: that was (blindly) adapted from https://github.com/wjakob/nanobind_example/blob/b372b366057d344e94dd8beb894fe308b276cee9/CMakeLists.txt#L28-L31. > Might be off-topic for this issue, but should that even be considered an error? I was concerned how...

Hmm, I took a closer look and it is weird because you are supposed to be hitting this branch: https://github.com/pybind/pybind11/blob/b9359ceadbf4d4b22509b684eea107d055b77901/tools/pybind11Common.cmake#L176-L184 Which does not call `FindPythonLibsNew`. Can you run it with...

Please run `find_package(Python3)` before importing pybind. Note that `find_package` is directory scoped so it should be in a top level `CMakeLists.txt`. That section is if-guared by [`Python3_FOUND`](https://github.com/pybind/pybind11/blob/b9359ceadbf4d4b22509b684eea107d055b77901/tools/pybind11NewTools.cmake#L25C29-L25C42) so if `find_package(Python3)`...

Yes, it is partially a `pybind` issue, but also using `find_package(Python3)` before `pybind` is perfectly fine and many cases recommended. That ensures that you are finding the python version you...

Those I'm afraid I'm not familiar with. It's on the container side of `cibuild_wheel`, @henryiii should be able to help with this when he's on.