Cristian Le

Results 920 comments of Cristian Le
trafficstars

Do you use a GHAction like `ilammy/msvc-dev-cmd@v1`? What issues do you see, is it in the compiler chosen or in the build artifacts produced?

There are various factors that influence the compiler detection, but generally it's environment variable `CC` and what resolves `cc` in `PATH` (similar for `CXX`). For window it should resolve to...

Afaik, there is no secret sauce for detecting compilers within `scikit-build-core`, and everything is based on how CMake detects it. There is a bit of manipulation for the `-G` generator,...

How about setting the `RPATH` relative to `$ORIGIN`. The issue here is that the installed artifacts have to be fully relocatable, i.e. if you copy the files around, it should...

You can set [`INSTALL_RPATH`](https://cmake.org/cmake/help/latest/prop_tgt/INSTALL_RPATH.html) and use `${ORIGIN}` inside it to point to the appropriate paths. Iiuc the cython library is defined by `add_library` or `python_add_library` right? Note that for windows...

Can you run `readelf -d` on the `transport_spatial_methods.cpython-311-x86_64-linux-gnu.so`. The other issue I see is with the installation paths of the targets, but I'm not sure in which library that symbol...

I was worried the `$ORIGIN` was being expanded, but it seems to work fine. The other part that I can think of is where do the symbols `f2pywrapmain_` get defined....

Nitpick: don't write stuff like `*_SRCS`, these are relics of `autotools`. Use `target_source` and such. Also avoid using `${PROJECT_NAME}` etc. for simple naming of targets, libraries, etc. it makes it...

For `-j` option I think it is better handled with [`CMAKE_BUILD_PARALLEL_LEVEL`](https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html#envvar:CMAKE_BUILD_PARALLEL_LEVEL). Other arguments though, that is fair-game. For reference what are the Gentoo build scripts for a CMake and python...