Cristian Le

Results 940 comments of Cristian Le

> Quick question: what is the the cmake build type? I believe we configure only Release, Debug and Coverage (custom one) in cmake/CompilerConfiguration.cmake Good question, it's `RelWithDebInfo`. But regarding that...

BTW, this is a Fedora packaging PR, we should discuss it on a CMake modernization one/issue. If you can open an issue can copy the discussion, we can continue there...

Well one design question, do we want to implement the same structure as cp2k/cp2k repo? In either case this PR is finished and ready for review as-is. The only tasks...

The testing here with packit and the CI in CP2K are completely different in subtle ways. Packit testing in cp2k never picks up the changes here, and the changes here...

> Please, consider DBCSR as an independent project. Of course, I was not assuming any dependencies, and I will be leaving that design issue to upstream. Packit does not have...

The tests taking `2136.78` on openmpi vs ` 209.08` on mpich or `80.11` on serial is fairly suspicious. The tests are oversubscribed, but still the discrepancy is too high. I'll...

Things are a bit muddy, because when building, the environment is very limited, and in the x86_64 case, there are only 2 cores available competing for both mpi and openmp...

> Note that the most expensive tests we have are really serial, so likely I will go for a single rank... Technically yes, but because these use ctest parallelization, the...

Small note about `TEST_MPI_RANKS`. It should be fixed to `2` instead of `auto` in order to better take advantage of `ctest` parallelization