Cristian Le
Cristian Le
Generally it is preferred to rebase and continue in the same PR in order to keep the discussion history, but if you feel like you need a fresh start at...
> Conflict, and were you planning any extra tests? Yeah, forgot about that one. Added the tests for `cmake.root`, but haven't thought of how to add one for `search.site-packages`
You can use something like: ```python from importlib.metadata import version if version('cmake') < ... ... ```
Unfortunately users probably ignore warnings until the last second. 72 hits that I was able to find: https://sourcegraph.com/search?q=context:global+scikit-build-core%5B&patternType=keyword&sm=0
Well since this is only observed at the build time, they would only see it in the CI, which they would generally be ignoring, until the optional dependency is actually...
> Creating files specifically for editable installations via build hooks is possible with the [`force_include_editable` build data option](https://hatch.pypa.io/latest/plugins/builder/wheel/#build-data). Hmm, but does `hatchling` provide its own `.pth` editable file and if...
> That being said, our `do_regtests` script has been refined for over 20 years and contains many bells and whistles that we have come to rely on. So, I don't...
PS: Feel free to check [my template](https://github.com/LecrisUT/CMake-Template/tree/main/test) about a design for the `ctest` testsuite. It includes unit testing, regression testing, packaging tests, and example testing. If you want to discuss...
Just saw that `CP2K_ENABLE_REGTESTS` makes it write files in the source folder. That is really bad and error prone in multi-build environments like when packaging and trying to build for...
I would *strongly* encourage not to reinvent the wheel when much of the complexity of `do_regtest.py` is handled already by `ctest`. Believe me that the parallelization and test scheduling of...