Kun Zhou
Kun Zhou
cc @wellwelwel @sidorares this was a pretty critical bug that caused data corruption for us, would love to contribute the fix to upstream
@wellwelwel thanks for taking a look! Basically my change is from ``` res = resNumber.toString() === resString ? resNumber : resString; ``` to ``` res = res.greaterThan(Number.MAX_SAFE_INTEGER) || res.lessThan(Number.MIN_SAFE_INTEGER) ?...
Hi @julien-duponchelle, could you take another look for this please? Happy to make updates to this patch as needed.
I had a a tangent issue where calling `end` on connections isn't emitting the `end` events, turns out it's because `close` sends `COM_QUIT` to the mysql server and emit the...
cc @wellwelwel bump on this
@wellwelwel I believe `error.code` is a number in the current code for `ER_CLIENT_INTERACTION_TIMEOUT` but we have always propagated the `error.code` to the client as a string elsewhere (for other errors)....
@wellwelwel Closing since it's not getting attention. Feel free to open and I can resolve the conflicts if that changes.
@wellwelwel I still think this is a critical bug that can cause database corruption, but closing since it's not getting attention. Feel free to open and I can resolve the...