Eric Dubé

Results 322 comments of Eric Dubé

After manually testing and reviewing this code I've come to understand that this is half a proxy implementation - it writes every proxied response to a file, overwriting the file...

Is there any way to test this? This should have tests before I merge it, if a unit test for this is complex I'll do a manual test later.

#872 (another websocket impl) was merged. The changes from this PR are present in #933, with a modification so it adds the `--websocket` flag to the existing implementation.

Merged #933. You should still get contribution credit on GitHub because I kept your commits in my modified branch and did a rebase-and-merge to preserve them. Also, please take a...

You can set `pub_port` to `443` in the config; this parameter allows you to set the port for the web page origin separately from the listen port. Thanks for bringing...

Is the api subdomain part of the (or has its own) certificate? That's one thing I can think of. The CORS error is confusing me because it looks like your...

> @KernelDeimos Is that something that can added for self-hosters? I think we can do that, and also have a mode where we use `/api` instead of `api. > need...

In case this is relevant, [I fixed a bug](https://github.com/HeyPuter/puter/commit/f9b375a39b482336e16f3983dca8c34b4654e331) that prevents puter from working when the main domain itself is a subdomain.

@jelveh would it be appropriate to add the `good first issue` label to this?