Eric Dubé

Results 332 comments of Eric Dubé

> > We have some documentation for this under [Self-Hosting instructions](https://github.com/HeyPuter/puter/blob/main/doc/self-hosters/instructions.md) but we don't have this linked in the README.md file anymore. If you have the time it would be...

Hi, thanks for opening this. Does this PR replace #1189? I'll do a manual test later today.

Just adding a note here since we talked outside the repo - this will be merged pending further review from @jelveh

I just did a manual test. The behavior of displaying notifications seems to be perfect now. I noticed only two issues: - minor cosmetic issue: contrast of the bell sometimes...

I just did a quick test: - I see the issue with clicking notifications has been fixed. - I noticed style changes in the top bar. These were present before...

> The notification panel does not depend on these changes. What should I do for the layout? Should I try to fix it or will it be considered as another...

> Sure then, let's merge it and I can try to fix it as another PR What I meant was the CSS changes made in the PR could be moved...

There are still styles changes. I want all the style changes for the toolbar removed - they don't need to be in this PR. That means comparing with the style...

Well, I was going to send a `.diff` or `.patch` file but, shockingly, GitHub doesn't support these file extensions; so instead, here's a `.txt` file which really is a diff....

Perfect, thanks! I'm going to ask @jelveh if he wants to review the UI first but otherwise this looks ready to merge to me