Jonathan Lorimer

Results 77 comments of Jonathan Lorimer

https://github.com/kolloch/crate2nix/pull/206 I think this PR would solve the issue?

@yusdacra Oh yeah, this worked! Thank you!

Also, switching to your branch seems to have resolved this issue https://github.com/kolloch/crate2nix/issues/207

I did also notice this warning. Not sure if its helpful. ``` trace: warning: crate2nix: Passing `buildRustCrate` as argument to Cargo.nix is deprecated. If you don't customize `buildRustCrate`, replace `callPackage...

I think it would be very worthwhile to get your branch merged. Especially since `crate2nix` is looking to release a verion `1.0`

Okay, after doing some more digging this got even weirder. If I just use `crate2nix generate` from within the directory, everything works as expected. Are there any notable differences between...

If it helps at all, the `crate-hashes.json` created by the `generatedCargoNix` is different from the `crate-hashes.json` generated when I call `crate2nix generate` #### generatedCargoNix ```json { "modelator 0.1.0 (git+https://github.com/informalsystems/modelator?rev=99f656fa8b3cf46a2aa0b6513e4e140d1778c4bd#99f656fa8b3cf46a2aa0b6513e4e140d1778c4bd)":"8532d146bd6d80f31e12285ebb7938e340226f7066a52deb4db126b16fc57ec8"} ```...

@AusCyberman I'm a bit confused, are you saying that the revision I am using for `informalsystems/modelator` is incorrect? Unfortunately I am not in control of the upstream Cargo.toml that references...

@isovector Do you think the terse option should just be a parameter to allow users to tune the threshold for triggering an error?

Oh I see. Yeah, the errors are trying a little too hard to be helpful.