JoergAtGithub

The outcome of the discussion above was, that it should go into 2.4.1 - wasn't it?

Welcome at Mixxx! As a first-time contributor we need you to sign the [Mixxx Contributor Agreement](https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ) and comment here when you have done so. It gives us permission to distribute...

This does seems not influence the performance on Windows11 - neither positive nor negative.

Did you tried how #12009 influence the library performance on macOS? There I noticed a performance gain on Windows.

Why not just calling stopTimer in your mapping script, before calling beginTimer? Where do you see the benefit?

In my opinion ``` if (previousTimerId) { engine.stopTimer(previousTimerID); } newTimerID = engine.startTimer(500, ); ``` is easier understandable code, than ``` newTimerID = engine.startTimer( 500, , true, previousTimerID); ``` To understand...

> fair, but the kinda already also need to do that to understand the purpose of the trailing oneshot bool parameter... Which is optional and does not occur in the...

Welcome at Mixxx! As a first-time contributor we need you to sign the [Mixxx Contributor Agreement](https://docs.google.com/forms/d/e/1FAIpQLScC9QG327sjLL0eWftmfGUasxFFLxg6LCXJ2xHDYRzFIRqyiw/viewform?formkey=dEpYN2NkVEFnWWQzbkFfM0ZYYUZ5X2c6MQ) and comment here when you have done so. It gives us permission to distribute...

The pre-commit check is failing. The best way to fix pre-commit issues is to install pre-commit locally on your system, as described here: https://github.com/mixxxdj/mixxx/wiki/Using-Git#set-up-automatic-code-checking Than it will fix these issues...

Target for this PR should be 2.4 not main. Please rebase.