JoergAtGithub

Results 441 comments of JoergAtGithub

Thank you for taking care! Maybe the easiest way to test, if a Windows build is affected is to build our Mixxx [2.4](https://github.com/mixxxdj/mixxx/tree/2.4) branch and execute the CTests. If you...

Is this supersedded by #13151, or is this additional?

Can you specify the exact Beta version, which were not affected?

I don't think multiple options per row are the issue here. The issue are the long description texts. Have a look on the narrow layout of the Traktor preferences, with...

This looks much cleaner now! 🤩 But for the multi option per row, the allignment could be improved. There is much space between the label and the control belonging to...

IMHO this looks really good now! You might want to tune the vertical whitespaces to improve the look further (more height for the checkbox options, move the Deck-Labels a few...

> In regards to the label/control arrangement: the are usually (always?) layed out horizontally => Label: [control] > Let's stick to that rule and not mix it with vertical layouts....

Could you merge upstream/main please, than all builds should pass.

I guess the reason is, that the 2.5 buildenv contains the latest libdjinterop version, while 2.4 contains an older one. Therefore the Mixxx 2.4 build downloads and includes the sources...

To fix the Windows build, you need to replace PRIVATE with PUBLIC in this line: https://github.com/mixxxdj/mixxx/blob/9770b5976d502ff55edac3286f93e25734b9c910/CMakeLists.txt#L2276 I will create a PR