Jeffrey Ying
Jeffrey Ying
Right as @benjaminjb mentioned, per the `durationMatcher` code, it looks like only integers are accepted and decimals are not. This is only if the string is not parseable by `time.ParseDuration()`...
Looks like go-openapi already has a PR to fix parsing negative durations: https://github.com/go-openapi/strfmt/pull/144
Is the ask that there should be an option for kubectl to return an error instead of warning if the skew is greater than 1?
/assign @thockin @jpbetz /triage accepted
/assign @aaron-prindle /triage accepted
/ok-to-test
/remove-sig api-machinery
What exactly is breaking by returning a pointer? This would be a backwards incompatible change so I'd be quite skeptical unless something is broken in a major way.
Ah I see, it looks like we have a mix of usages of the pointer and struct https://github.com/kubernetes/kube-openapi/blob/2c72e554b1e7755b5fbee01cc910063070d5b4ec/pkg/builder/openapi_test.go#L62 https://github.com/kubernetes/kube-openapi/blob/2c72e554b1e7755b5fbee01cc910063070d5b4ec/test/integration/testdata/custom/v2.go#L27 and since nothing validates the interface implementation, both tests pass 😓...