Jeffrey Ying

Results 93 comments of Jeffrey Ying
trafficstars

/assign @thockin (api review)

@thockin: will rebase before merging

I'm dealing with some CI issues so will be pushing to this incrementally. Feel free to hold off on further review until they're fixed.

> I don't understand this statement. If I have two candidates and one thinks we're using strategy x and fills in the x parameters, and the other thinks we're using...

Overall like the strategy. A couple questions > First, he sees `Lease.strategy` as an extension point. I'm OK with that, but it means we need to spec it clearly. e.g...

> They won't be ignored, though -- you could have a "new" component request "strategy=NewestVersion, supercedes=[OldestVersion]" and the CLE would change strategy. Components write to strategy and supercedes fields in...

> SGTM! I think the rule I had missed was that CLEs never ignore strategies, even ones they don't recognize. So if a CLE sees that the best strategy is...

Optimized this to calculate state without any locking involved and moved to using only one queue (for election). All informer events are basically filters for whether an election step needs...

> Hi all, I am going to be AFK for the last 20 hours before code freeze, which leaves me with basically 1 day to approve things. I was LGTM...