JanDintel comments

Results 6 comments of


                                            JanDintel

Allow a default value when the attribute is assigned as nil, with the :allow_nil option

Could you have a look at this MR @elskwid?

Allow a default value when the attribute is assigned as nil, with the :allow_nil option

Maybe you could have a look @solnic?

Allow a default value when the attribute is assigned as nil, with the :allow_nil option

@solnic Maybe it's just the name of the option (`:allow_nil`) that puts you off. But I think this feature/fix is a good addition to Virtus, while staying backwards compatible in...

Ignore JSON keys order when stubbing a request fixes #485

How stable is the the build? Because the build even fails when changing nothing, see: https://travis-ci.org/JanDintel/webmock/builds/159343501

Ignore JSON keys order when stubbing a request fixes #485

@bblimke Thanks for your response. The main reason behind the pull request is because I ran into this issue while using the gem and the issue was reported in #485....

Ignore JSON keys order when stubbing a request fixes #485

I wanted to keep the change small and 'relevant'. Therefore I kept my change to the JSON bodies specifically, since there was only a issue reported regarding the ordering of...