J.P. Toro
J.P. Toro
Hi @yonat, just wanted to check in and see if you have any questions or concerns about my pull request.
Sounds good—thank you!
Hey @yonat. Just wanted to circle back here and see if there's any update on the pull request.
Just pushed a new commit with your requested revisions. Let me know if you need anything else after you run and test!
Excited to see them—go for it!
Very nice—especially the simplification of HistoryTokenStorage. One question: why go with classes over structs for its concrete implementations? Wouldn't structs be more lightweight?
Ah I see, don't know why that error didn't come up on my end. Everything looks great—thanks again for the improvements.