Joseph

Results 92 comments of Joseph

`Document` has some functions that should reference embedded document types rather than *all* document types, but since the const currently includes regions they throw errors. There are TODOs marking these...

Also, need to update the appropriate space in CONFIG and types in `common/documents/_types.d.mts`

Note: https://github.com/foundryvtt/foundryvtt/issues/11505 is tracking a signature-affecting bug for `Macro#execute` and may change things in v12.301 or later.

`Combat#combatants` is the one I'm currently looking at in SWADE; it's giving `Document.Any`

Possibly blocked by #2580

I wonder if this could be used for Flags, since there's supposed to be the package ID as a namespace layer before the *actual* flag keys. So instead of just...

Some more - What to do when the core type documentation is wrong - Deprecation handling - Explanation of `fields.mjs` - Policy for `protected` vs `internal` vs `private`

Moved to https://github.com/foundryvtt/foundryvtt/issues/12436

another TODO left from #2600 and #2743 - remove DocumentModificationContext. - Foundry leaves the `options` for `_preCreate` functionally untyped (object without corresponding typedef) - Type should be an easily extensible...