Iceber Gu
Iceber Gu
I'd like to provide a third option besides `*time.Time` and `CreatedAtIsSet`, although it may not be a better one. `*time.Time` makes it look less uniform with other structures(Container, Sandbox...), and...
We need to upgrade controller-tools first https://github.com/kubernetes-sigs/controller-tools/issues/880
Thank you very much for the report, I will analyze it
@klihub I changed the call to syncFn after each pre-install plugin launch to only call syncFn once after all plugins are launched, which avoids unnecessary multiple calls to syncFn in...
Hi @mikebrow @klihub Do you have any new ideas for this pr? I think synchronizing all and reporting back all errors is a good way which gives a more complete...
> That said, I think synchronizing pre-launched plugins is only/really relevant for the case when an already active runtime (with existing containers) gets restarted (after all, on initial startup the...
> @Iceber wdyt about the logging changes.. Sorry I missed the email on this pr, I'll take care of it soon
@mikebrow I've added a new commit for better viewing of the changes I've returned plugins that failed to start to syncFn via syncPlugins. after all, those plugins that didn't start...
@mikebrow @klihub updated to print logs only, PTAL, Thanks
Thanks, I would also love to have more detailed details on how to move forward with https://github.com/containerd/containerd/issues/7739 (e.g. completing each task of the issue design). I'm probably most interested in...