Iceber Gu

Results 158 comments of Iceber Gu

Sometimes abstracting functions that are not reused or independent enough can lead to incoherent code, and it may be clearer to distinguish a set of logic by ordered line breaks...

BTW, I saw some warnings that there are some linters that are deprecated. ```bash golangci-lint run WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems...

Yes, comments are necessary, and clusterpedia lacks a lot of them, including function names, logic within functions, and field comments within clusterpedia-io/api. We can add them and I will also...

@cleverhu We have migrated the chart to the https://github.com/clusterpedia-io/clusterpedia-helm for maintenance, please submit pr to the https://github.com/clusterpedia-io/clusterpedia-helm, thank you!

https://github.com/clusterpedia-io/clusterpedia-helm repo has been created

Local charts are deprecated, but we will not close the page and delete charts/index.yaml so that existing users can continue to use them. Now e2e tests still use local charts,...

/lgtm @wzshiming Could we merge it now?

We do not currently return a specific error when a cluster does not exist. It seems to make sense to tell the user that the requested cluster does not exist

/lgtm @muma378 Thank you for adding the kubevela import policy