Eldred Habert

Results 517 comments of Eldred Habert
trafficstars

Shouldn't this PR be made against https://github.com/kemenaran/SameBoy? It seems like the compilation errors stem from a patch added in *that* repo's `wide_gb` branch.

Does this belong to upstream? Especially if it's not tested, and no front-end uses it...

Without the line number, how would you suggest one applies the mentioned changes?

I'd also like to mention that I have in mind to present those projects as proper Git repositories, and using `libgit2` to extract the diffs and present those in the...

There are at least three categories of invalid code: - Things that would syntactically make sense, but are not supported (`add b, c`, `ld de, hl`) - Syntax bikeshedding (`jp...

Hmm, sounds interesting. But what about `ld hl, sp + 2`? And, beyond that, what would we *do* with that parse? If what you have in mind is to report...

I think we have the same (general) idea in mind, yes.

Good idea! I just think that this file should be tweaked further. It's also a good idea to install some MIME type detection files to integrate even better; you can...

This gets funky. To allow the channel to be resumed when the muting ends, this state needs to be persisted—so we can't write directly to `NR51`. This means that the...