fortISSimO icon indicating copy to clipboard operation
fortISSimO copied to clipboard

Muting a channel does not disable stereo effects for that channel

Open DevEd2 opened this issue 1 year ago • 3 comments
trafficstars

DevEd2 avatar Sep 09 '24 23:09 DevEd2

This gets funky. To allow the channel to be resumed when the muting ends, this state needs to be persisted—so we can't write directly to NR51. This means that the user will have to manually commit that intermediate variable to NR51 themselves, combining any (e.g.) SFX bits themselves.

That's arguably one more layer of complication, and it's not what hUGEDriver does either. So I think it should be opt-in.

What do you think?

ISSOtm avatar Sep 10 '24 19:09 ISSOtm

I can't speak for everyone, but as someone who's working on a sound effect driver I feel like the option to change the stereo behavior in regards to muting would definitely be appreciated. A toggle would be the best option IMO, that way people working on e.g. a demo don't have to deal with any additional overhead caused by the required tweaks.

DevEd2 avatar Sep 11 '24 15:09 DevEd2

Then I'll work on that!

ISSOtm avatar Sep 11 '24 15:09 ISSOtm

Done in 195c125

ISSOtm avatar Jan 03 '25 00:01 ISSOtm