Hayden Heales

> I know this is a WIP, but just in case you missed it, there are compiler errors with this PR: > > ``` > /home/buildbot/amd64-ubuntu-2004-debug/build/plugin/server_audit/server_audit.c: In function ‘void flush_buffer(const...

Currently Investigating: The server_audit_buffer_size.test is failing inconsistently in the CI environment but passing on my local machine. The hypothesis is that there might be a race condition causing a very...

> I think "dedicated thread" that is doing nothing, just waiting most of the time is a wrong idea. MySQL has multiplied threads for anything possible, "a thread that is...

@LinuxJedi @vaintroub I have now updated the branch with your suggestions. The details about the implementation and its benchmarking scores can be found on this [JIRA](https://jira.mariadb.org/browse/MDEV-34680?filter=-2). Please let me know...

> This is much better, thanks! you got rid of extra thread that I was complaining about. > > But, as I commented, there is > > 1. No reason...

> Looks good for me. As this is a bug fix, it should go into the oldest maintained release, which is 10.5. > > Can you please rebase to that?...

> I think it is a good feature to add, many thanks for the contribution. > > I've added a couple of comments for some minor things. Also, the following...

Currently working on work-around for windows specific failing audit plugin test

All failures have now been resolved. Please note that the failing tests were pre-existing and are not related to this recent change.

#3425 All the failing tests are confirmed to be on main branch and not due to any changes made in this PR