Hammad Bashir comments

Results 152 comments of


                                            Hammad Bashir

When a collection is updated with an existing collection name, raises an Exception

Closing in favor of #519

`get_or_create_collection` should take an (optional) embedding function

So it looks like the local.py and fastapi.py implementations _do_ in fact take the embedding function and plumb it through. But just the abstract class does not highlight it. #307...

`get_or_create_collection` should take an (optional) embedding function

Closed by #307

HNSW Defaults to 4 threads

B. https://en.cppreference.com/w/cpp/thread/thread/hardware_concurrency

Organize Configuration Settings in config.py

Hi @adkri - this is great, but I think this would result in a breaking API change for users because the way you create the relevant settings changes. My intuition...

Row Oriented `add`

For the JS api, would using this also work? To solve the problem mentioned in #254 https://simonsmith.io/destructuring-objects-as-function-parameters-in-es6

added missing embedding_function param in get_or_create_collection

@shivankar-p Right now the test doesn't check if the embeddings themselves are the same, just that they exist by looking at the len() could you add that?

added missing embedding_function param in get_or_create_collection

Thank you - This looks great! I think we can tackle that on a separate PR if you are up for that!

Inconsistent behaviour when filtering by metadata using $or

How much data do you have and whats the distribution across categories? I attempted to repro https://colab.research.google.com/drive/1glfVqsOOVxyLsJfmIq1GJBd9pazu1e-T#scrollTo=iWGs42guud0w In this colab, and am seeing results for both categories. So am not...