Organize Configuration Settings in config.py

Open adkri opened this issue 2 years ago • 1 comments

This pull request organizes the configuration settings in the config.py file by grouping related settings into separate classes DatabaseSettings and ServerSettings. These classes are then included as submodels in the main Settings class.

Apr 09 '23 12:04 adkri

Hi @adkri - this is great, but I think this would result in a breaking API change for users because the way you create the relevant settings changes. My intuition is that we should leave this as is for now since the refactor is mostly for cleanliness and not for functionality since it would break the API for users. What do you think about that?

Apr 10 '23 19:04 HammadB

Going to close this issue for now as it is stale. @adkri happy to re-open it if you like to jump back in!

Apr 22 '23 01:04 jeffchuber