Hammad Bashir
Hammad Bashir
This is already persisted as part of the "PersistentData" in the persistent hnsw segment isn't it?
* **#2206** * **#2205** * **#2204** 👈 * `main` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @HammadB and the rest of your teammates...
* **#2206** 👈 * **#2205** * **#2204** * `main` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @HammadB and the rest of your teammates...
* **#2206** * **#2205** 👈 * **#2204** * `main` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @HammadB and the rest of your teammates...
yea np, the reason its space is because thats the user facing term. They set "hsnw:space"
Looks good overall - can we patch the broken test and then I can rereview?
* **#2226** * **#2224** * **#2222** 👈 * `main` This stack of pull requests is managed by Graphite. Learn more about stacking. Join @HammadB and the rest of your teammates...
What do you mean by hugging face is blocked?
I suspect your vectors are not normalized but you are using cosine distance, for performance reasons we don't normalize the vectors for you in the index. The utils distance function...
I think we can remove chroma-hnswlib from our dep tree now, as its bundled in our rust impl. That should fix this class of issues that required a c++ compiler...