chroma icon indicating copy to clipboard operation
chroma copied to clipboard

[ENH] support multiple queries in rust vectorreader

Open HammadB opened this issue 1 year ago • 2 comments

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Update test_sanity to excercise n > 1 queries.
  • New functionality
    • This makes the hsnw query orchestrator able to respond to multiple queries, as the contract for it expects.

Test plan

How are these changes tested? Updated test_sanity

  • [x] Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Documentation Changes

None

HammadB avatar May 15 '24 02:05 HammadB

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chroma ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2024 10:27pm

vercel[bot] avatar May 15 '24 02:05 vercel[bot]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • [ ] Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • [ ] Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • [ ] If appropriate, are there adequate property based tests?
  • [ ] If appropriate, are there adequate unit tests?
  • [ ] Should any logging, debugging, tracing information be added or removed?
  • [ ] Are error messages user-friendly?
  • [ ] Have all documentation changes needed been made?
  • [ ] Have all non-obvious changes been commented?

System Compatibility

  • [ ] Are there any potential impacts on other parts of the system or backward compatibility?
  • [ ] Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • [ ] Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

github-actions[bot] avatar May 15 '24 02:05 github-actions[bot]

  • #2206 Graphite
  • #2205 Graphite
  • #2204 Graphite 👈
  • main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @HammadB and the rest of your teammates on Graphite Graphite

HammadB avatar May 15 '24 22:05 HammadB