Hannes Papenberg comments

Results 310 comments of


                                            Hannes Papenberg

[5.2] Replacing Fact::getLang() with Fact::getApp()->getLang()

We all agree that this is wrong, so I'm closing this PR again. :-)

stripos null user agent warning

Thank you for proposing this. As @Quy provided a better alternative, we are going with that one. Because of that, I'm closing this one. Thank you for your time.

[5.2] Add the "none-ID" behavior to the CRON Scheduler

I understand what you are trying to do, but I think your issue is solved with #43164. Can you check that?

[5.2] Add the "none-ID" behavior to the CRON Scheduler

To be honest, I'm hesitant to merge this if it isn't necessary anymore due to #43164. It feels like change for the sake of change then. I will bring this...

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Can you fix the codestyle?

[5.2] Add the "none-ID" behavior to the CRON Scheduler

The article id issue is solved by now.

[5.2] Add the "none-ID" behavior to the CRON Scheduler

Yes, this was the plan. But for that to happen, it would have required to have been tested. Unfortunately that didn't happen in time. With beta 1 we had a...

Pagination Issue with J2Store

Since this is not a Joomla core bug, I'm closing this one.

[6.0] Remove class-level event dispatcher dependency in plugins

I'm sorry, but looking at the registerListener, this wont be able to be merged into 5.x and would have to wait for 6.0 at least.

[6.0] Removing MCrypt class

Do you know in which versions we used MCrypt for 2FA?