Hannes Papenberg comments

Results 306 comments of


                                            Hannes Papenberg

[6.0] Unify loadFormData() to return an object

4 out of 43 models in our system return an array instead of an object.

Options for exclude module from child page

This is a b/c break and can not be merged into 5.x. you will have to rebase this to 6.0. regardless of that, I don't think this is a good...

[5.2] Fix reCAPTCHA Invisble error getElementsByClassName().forEach is not a function

Thank you for this fix!

Add SQL Insert for Email Templates

If you want to properly insert a mail template upon installation of an extension, you would call `\Joomla\CMS\Mail\MailTemplate::creatTemplate()` in your installation script. For the columns: * template_id: Unique string to...

Com_contact>field>email> new custom field's default value is misleading by being not authorized to public for modification

Hello @joomlafun, thank you for reporting this. Yes, the interface is not entirely intuitive and we should improve this in the future, however right now I have to say that...

[5.3] Add CI Github workflow

Why are you running the system tests on chrome and not Firefox like right now?

[5.3] Add CI Github workflow

Since we are using our own docker image for the cypress tests, firefox should still be available.

[5.2.] Fix Dark mode in user-captive view - Fix for Issue #43448

Thank you for your contribution!

[6.0] Fix tagged items URLs for items with the same view

I reviewed your change and it indeed fixes the issue. A good catch. However, I see 2 theoretical issues: 1. What if someone extends from this class? Since `$lookup` is...

[6.0] Fix tagged items URLs for items with the same view

The problem is, that it doesn't fail. If you have 2 components which have the view "category" and use their own category implementation, they (can) collide here and you have...