Forbes Lindesay
Forbes Lindesay
I'm not going to fix this, but if someone wants to submit a fix with a test - or at least a clear step by step plan of how to...
sync-request does not support being used in VSCode Plugins. This is working as intended.
I haven't added proxy support, since it's not something I would use. If you want it, I suggest opening a pull request to https://github.com/ForbesLindesay/http-basic as the first step towards implementing...
I'm locking this issue to prevent more "me too" style comments, if you want to implement proxy support, please start submitting pull requests.
This is caused by sync-rpc's attempts to do cleanup. If you attache the `process.on('exit'` handler before you `require('sync-request')` it works fine: ```js console.log('Process started'); process.on('exit', () => { try {...
I think any kind of execution during exit is going to be a special case for sync-rpc. The problem is that one of the cleanup tasks we must do is...
At the moment, nobody's done the work to make those two things function together, so just removing the conditional would not be enough to make it work. How would the...
Doing both things seems like a really dirty hack. You end up with a bonus global either way.
@jmm You either end up with `require` when you didn't want it or `ModuleName` when you didn't want that. Either way you lose because you wanted something else. @piranna that...
It's probably worth noting that this method of removing requires should be pretty fast, in contrast to using `derequire`, which required figuring out the complete scope chain in order to...