EugeneTorap

Results 43 comments of EugeneTorap

@michael-s-molina Can we merge it?

Hi @lilykuang! I see you removed `react-virtualized` from `package.json`. Should we rewrite existed code which uses this lib?

They don't update the lib during 2 years. I've started rewriting FilterableTable in order to use our new AntD table.

@eschutho @eric-briscoe @lyndsiWilliams I have some nice suggestions! - This is the new dataset creation page and we have [[SIP-61]](https://github.com/apache/superset/issues/13632) - `Improve the organization of front-end folders` created by @michael-s-molina...

Hi @mayurnewase! Do you have some time to finish the PR?

@cemremengu Thanks. Can you format a file with black to fix CI: Python Misc / pre-commit (3.8)? ``` pip install black black superset/tests/integration_tests/reports/commands_tests.py ```

@cemremengu We use `Excel` name instead of `XLSX` in our https://github.com/apache/superset/pull/22006 PR Can we use the `Excel` name for email alert/report UI logic? ![image](https://user-images.githubusercontent.com/29536522/205895111-49fe7e0c-ed11-4107-80dc-8b19518ad575.png)

I think yes, need to replace all UI label from `XLSX` to `Excel` in this PR for name consistency. @villebro @zhaoyongjie @michael-s-molina What do you think?

@cemremengu Value must be `XLSX` but label is `Excel` ``` {t('Send as Excel')} ```