EugeneTorap comments

Results 43 comments of


                                            EugeneTorap

fix: Use Welcome page in SPA

Can we simplify Home page's path and use `/home` instead of `/superset/welcome`? What do you think @michael-s-molina @kgabryje @stephenLYZ?

fix: Use Welcome page in SPA

Who knows how to fix such error in `Menu.test.tsx`: `Error: Uncaught [Error: Invariant failed: You should not use outside a ]`

fix: Validate required fields in sql_json API

@hughhhh @betodealmeida Can you review it?

fix: Validate required fields in sql_json API

> Hi @EugeneTorap, Thanks for adding validation on the endpoint. Do you mind following the [Mashmallow](https://marshmallow.readthedocs.io/en/stable/) validation schema for the requesting validation? Here are some [examples](https://github.com/apache/superset/blob/665007622845cf4303b50e57d11549a162dbbb1b/superset/views/datasource/views.py#L190-L195). Thanks, will do it

chore: Support Python 3.10 and bump pandas 1.4 and pyarrow 6

@hughhhh @betodealmeida Can you review it?

chore: Support Python 3.10 and bump pandas 1.4 and pyarrow 6

How should I fix this test? Pandas returns 0 instead of nan for the API

chore: Support Python 3.10 and bump pandas 1.4 and pyarrow 6

@betodealmeida @villebro Can you review again?

perf(sqllab): Rendering perf improvement using immutable state

@eschutho @michael-s-molina Can we merge the PR?

fix(dashboard): Fix scroll behaviour in DashboardBuilderSidepane

@michael-s-molina @kgabryje @lyndsiWilliams @hughhhh Can you review it?

chore: refactor ChartHolder to typescript + tests

@diegomedina248 Thank you for this PR! I have a SqlEditor refactoring into FC, can I share the code with you? @michael-s-molina @kgabryje Can we merge the PR?