arcgis-maps-sdk-swift-samples
arcgis-maps-sdk-swift-samples copied to clipboard
Esri
SwiftUI samples demonstrating various capabilities of ArcGIS Maps SDK for Swift
## Description This PR implements `Show grid` in `Maps` category. [URL to README](https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/Ting/New-ShowGrid/Shared/Samples/Show%20grid/README.md) ## Linked Issue(s) - `swift/issues/5370` ## How To Test Try all combinations of the settings. ## Screenshots...
## Description This PR implements `Filter by definition expression or display filter` in `Search and Query` category. URL to README: [README](https://github.com/Esri/arcgis-maps-sdk-swift-samples/tree/Caleb/New-FilterByDefinitionExpressionOrDisplayFilter/Shared/Samples/Filter%20by%20definition%20expression%20or%20display%20filter) ## Linked Issue(s) - `swift/issues/5369` ## How To Test...
`foregroundColor` is [deprecated](https://developer.apple.com/documentation/swiftui/view/foregroundcolor(_:)), Use [foregroundStyle(_:)](https://developer.apple.com/documentation/swiftui/view/foregroundstyle(_:)) instead. Same for other usages below
A few people left feedback on that an empty "Favorites" category tile may be confusing to first time users. - Phil: https://github.com/Esri/arcgis-runtime-samples-ios/pull/1159#discussion_r866243170 - Lucas: When the app opens, the first...
Currently it doesn't have a preview. See #403 latest comment
The status in the `Monitor changes to layer view state` sample should be stored instead of the formatted string describing the status. See [this feedback](https://github.com/Esri/arcgis-maps-sdk-swift-samples/pull/395#discussion_r1580239897). ```swift Text( """ Layer view...
https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/1427b7f7eb4b2217ea6319dbe8d12be6d19fe570/Shared/Supporting%20Files/Views/CategoriesView.swift#L50
https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/b068fdae82d66b88107a508093130d0a85e92200/Shared/Samples/Sketch%20on%20map/SketchOnMapView.swift#L216-L230 According to [this discussion](https://forums.swift.org/t/for-await-loop-wrapped-in-a-task-block/64159/2), there might be a retain cycle in these 2 Task blocks. Check in debugger and fix if needed. --- More to be fixed https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/62fea7a27765ad2866817db16e7b5ec9e4f47574/Shared/Samples/Download%20preplanned%20map%20area/DownloadPreplannedMapAreaView.Model.swift#L104-L107 https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/62fea7a27765ad2866817db16e7b5ec9e4f47574/Shared/Samples/Find%20route%20in%20transport%20network/FindRouteInTransportNetworkView.Model.swift#L94
Currently some types aren't correctly limited to the least access level. An example https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/05b3a37f1419d9bedc98fe5a82a62635e63a2a4e/Shared/Samples/Create%20and%20edit%20geometries/CreateAndEditGeometriesView.swift#L227 The data model type can be `private`, but is `internal` right now. In a very rare...
In 200.0.0-beta, because we used the StateObject-for-map pattern, many view properties are created as type property, or gets their default value from a static method. This is not a memory...