David Sisson
David Sisson
Be wary, Gluten contains a copy of Substrait instead of depending on the main repo. As a result its Substrait is incompatible with the rest of the ecosystem. That works...
If the count is not specified (i.e. omitted in the wire proto) then the semantics you are looking for are available. Is the problem that most consumers are performing a...
The related documentation link is [here](https://github.com/substrait-io/substrait/blob/main/site/docs/relations/logical_relations.md?plain=1#L294). I prefer to keep the required/optional semantics in the file (i.e. close the definition) to make this easier to keep track of for this...
So the documentation is the problem. While we're looking at issues with the documentation is there any reason that count has to be positive? Zero seems quite reasonable from a...
The behavior for scalar fields changed in v3.15.0 to add back optional as it was in proto2: https://github.com/protocolbuffers/protobuf/releases/tag/v3.15.0 If we don't want to require that version (from 2021) we could...
The default behavior for fields since that version is optional. It's probably been optional for the entire existence of Substrait but we haven't treated it that way. (Also one of...
It does look that way. So messages default to optional and fields default to required. That's going to take some getting used to. So do we just go the sentinel...
Addressed in #627.
How do avg_snowflake and avg differ? Are there just missing options? Yes, most of the consumers don't handle options today but would handling them solve the problem more cleanly? As...
For most plans there is only one PlanRel which contains a root. That represents an entire plan. The reason you can have multiple PlanRels I believe is for communication purposes...