DmitryMak
DmitryMak
We rely on IDisposable returned from Push. Could you help us understand how this will fix the ArgumentNullException?
Based on my experiments it is a bug ConvertToArrayFilter. When I turn it off by removing `` in the config, the exception disappears. The underlying issue that we were having...
> You are right, it does work, my bad :) > Anyways, it seems either somehow instead of "Alice" you send null or somehow the value is overwritten to null...
My understanding is that explicit Pop call is not required. Based on log4net documentation for the Push, they seem to recommend this pattern: ``` using(log4net.LogicalThreadContext.Stacks["NDC"].Push("Stack_Message")) { log.Warn("This should have an...
I have do a bit more research on this, but IMHO ToArray filter needs to be fixed to behave like ToString filter. ToString does not crash in the same scenario.
> @dceuinton The core idea of this rule is to discourage exposing _mutable_ or _cloned_ data structures through properties. It is a good API design principle to keep properties lightweight...
@gewarren done: https://github.com/dotnet/runtime/issues/97298
> Ok. I've fixed tests... But they still fail. Seems legit bug. Thank you! FWIW I tried to use `collection-type` and a custom IUserCollection with Wrap overridden to wrap the...
Essentially I want to implement a small immutable collection that is compared by value (SequenceEquals). It looks like my only option is to serialize the collection into a string and...
@hazzik I submitted a PR with a test that explains what I meant. Though I'm not sure how to write an assertion that fails when an unexpected DML is issued.