Darren Jacques

Results 8 comments of Darren Jacques

I like the idea. However, my blocking concern is that they overload the clock interface with methods that don't have analogs in https://pkg.go.dev/time, rather they are functions from https://pkg.go.dev/context I'd...

> So, implementing context.Context is not enough I think I may have miscommunicated. Do you agree that *something* needs to implement `context.Context`? If your response *no* I think we have...

See comment in #92, conversation continued in #94.

"*the timer channel associated with a Timer or Ticker is now unbuffered, with capacity 0.*" seems like a problem on first read. We can't quickly iterate over multiple expirations during...

More thoughts: I think it is reasonable to offer 2 versions to the caller, a blocking and non-blocking version, #1 and #4 above. `Advance()` should probably go unchanged, although it...

From my perspective, I'm not generally supportive of making `BlockUntilContext` even more complex. It's behavior is already kinda racey and hard to manage.

Despite being a maintainer, I don't particularly love `BlockUntilContext`, because in concurrent code it can be racey. I have not found a great way to use it in my own...

Make sense. I admit I have a lot of... I guess the term is "maintainer bias"(?) Happy to accept contributions, particularly on documentation because of that bias.