Duncan Brawley

Results 14 comments of Duncan Brawley
trafficstars

There will be a corresponding [SPIRV-LLVM-Translator](https://github.com/KhronosGroup/SPIRV-LLVM-Translator) pull request soon.

> There will be a corresponding [SPIRV-LLVM-Translator](https://github.com/KhronosGroup/SPIRV-LLVM-Translator) pull request soon. Now up here: https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2559 Needs to be merged first and then eventually pulled into DPC++. Then two tests in this...

Pinging @intel/bindless-images-reviewers @intel/dpcpp-spirv-doc-reviewers

https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2559 Has been merged.

Important note: The `extensions/bindless_images.cpp` and `extensions/bindless_images_SPIRV_inst.cpp` tests will not pass until the commit from https://github.com/KhronosGroup/SPIRV-LLVM-Translator/pull/2559 is pulled into DPC++. It seems to me it happens automaticity every week or two?

Now has SPIRV-LLVM-Translator changes. Hopefully CI will pass.

> Comments about tests could be resolved in a different PR. Good idea. I will double check with my team. Should be fine.

> > Comments about tests could be resolved in a different PR. > > Good idea. I will double check with my team. Should be fine. @aelovikov-intel On your comment...

@intel/llvm-gatekeepers Should be ready to merge. There are some failing tests but all of them look unrelated to the changes here.