D33r-Gee

Results 52 comments of D33r-Gee
trafficstars

tACK on Android armv7 everything worked as expected The `settings.json` was created after the onboarding with the following values: `{ "prune": 2861 }`

tACK https://github.com/bitcoin-core/gui-qml/commit/61f8e6c5fcb0c6c31a6283c3b7fdf6b9f82eba5e On Ubuntu 22.04 and Android (armv7) Works as expected, settings.json shows defaults: ``` { "listen": true, "prune": 1907 } ```

Thanks @johnny9 for commenting and reviewing! > During testing, I was unable to start the app after onboarding. The initial onboarding flow worked, however, It appeared to not find the...

updated the commits from [87b4d75 ](https://github.com/bitcoin-core/gui-qml/commit/87b4d75a9275c92236aa4654f714d9739e2a81d9)to [76f83f2](https://github.com/bitcoin-core/gui-qml/commit/76f83f25945f12317f42c0da1387e4da6aba282d)

> At the end I found I needed also this one `qml-module-qtquick-dialogs`, so please update the section accordingly if you think this is correct. Great catch @pablomartin4btc! Updated the description

> Another thing I noticed is that once I close the app if I delete the test chain subdirectory of the custom datadir (eg signet), which contains the `settings.json` file,...

> As part of this PR, shouldn't we show the custom datadir that has been selected by the user somewhere? Perhaps as a non editable field in the Storage settings...

> Let's make this draft as it still needs a good bit of work. It's a requirement that changes need to work with all builds (dynamic + static) Great... I'll...

> it crashed once when clicking _Custom_ at _Storage Location_. [9513874](https://github.com/bitcoin-core/gui-qml/commit/951387487f0ad187d646f7c4b96f37c1e01d431d) > > terminal output > > ``` > Gtk:ERROR:../../../../gtk/gtkpathbar.c:1342:set_button_image_get_info_cb: assertion failed: (cancellable == data->button_data->cancellable) > Bail out! Gtk:ERROR:../../../../gtk/gtkpathbar.c:1342:set_button_image_get_info_cb: assertion...

Based on @pablomartin4btc and @johnny9 feedback: Converted to draft for now and will post follow up PR with only the UI elements for more straight forward reviewing and merging.