D33r-Gee

Results 52 comments of D33r-Gee
trafficstars

Thanks @pablomartin4btc for testing and reviewing > I noticed another bug which is: if the user clicks on custom... addressed this with the latest push from [2a301e1 ](https://github.com/bitcoin-core/gui-qml/commit/2a301e117f6e83611b08a3d6242ed6aaa1f4caa5)to [61e775b](https://github.com/bitcoin-core/gui-qml/commit/61e775b0d7f18328e6f04e6a99cb70017fe00539) Now...

Thanks @GBKS for testing and reviewing... This: > Tapping anywhere in the directory option should activate it. This does not seem to work when tapping the light grey directory display...

with the latest push from [b941932 ](https://github.com/bitcoin-core/gui-qml/commit/b941932926a55144d78e2ae07b721cf38ad48639)to [0c46cae](https://github.com/bitcoin-core/gui-qml/commit/0c46caeac5c9f9166ae8891987f1f9bf626dbd4d) addressed @GBKS comment regarding the proper color for datadir display, by adding a new `state` ("DIRECTORY") in ValueInput.qml Next is addressing this:...

new commit [855cea5](https://github.com/bitcoin-core/gui-qml/commit/855cea5fd27d227ce595cb06a3fd281438a6d0b6) addressing this use case > And if the user goes to the directory picker and cancels out of it, the previously picked option can remain active. That...

rebased new head is ce6866a9adf408625f6506497f9e78b6b663cadf

Updated from [ce6866a ](https://github.com/bitcoin-core/gui-qml/commit/ce6866a9adf408625f6506497f9e78b6b663cadf)to [2e2fe79](https://github.com/bitcoin-core/gui-qml/commit/2e2fe79b5af3262fca050d98fbbb639ccb0d6343) Main changes were implementing @johnny9 and @pablomartin4btc feedback... RE: `customDataDir` bool, decided to go with a dynamic setting of `dataDir` since the bool options was...

> Seems to be an issue with building the Android target > > "qml/models/options_model.cpp:186:55: error: no matching member function for call to 'replace' m_custom_datadir_string = m_custom_datadir_string.replace("content://com.android.externalstorage.documents/tree/primary%3A", "/storage/self/primary/");" Thanks for discovering...

> one nit/UX thing: select/have a custom data dir -> select default data dir -> select custom data dir -> it prompts the folder location selection again. for me it...

> The MacOS workflow runs seem to fail for this PR (also for 401). Would it be possible to fix those to simplify testing? Hmmm... well that's problematic... will discuss...

tACK on WSL Ubuntu 22.04 on `signet` Works as expected, the settings file gets created after the onboarding has finished. settings.json: `{ "listen": true, "natpmp": true, "prune": 2861 }` Do...