ConnorJC

Results 132 comments of ConnorJC

I see that there is support introduced for MetalLB in BGP mode with #354 (and #355). However, could I suggest adding support for the ARP mode as well? I know...

@murali-reddy Ah, I read [this blog post](https://cloudnativelabs.github.io/post/2017-05-10-kube-network-service-proxy/) and because of it I was under the impression that IPVS proxy wouldn't be created for LoadBalancer services. However, if that isn't the...

@amilanoski could you provide a full test case for scenario 1? When testing, I get scenario 2's behavior (using the default EBS key) when specifying `encrypted: "true"`. Are you sure...

I don't think this is suitable to implement in the driver: 1. Internally, the driver is largely built around the idea that 1 kubernetes volume maps to 1 EBS volume...

@czomo it's not exactly convenient, but I believe you should be able to manually create a new PV (and if necessary, PVC) that explicitly specifies the old volume by using...

Yeah, that's the basic idea. Currently, the external driver doesn't reconcile the volume type of already-created volumes at all, so you could do step 0 at any point during the...

/hold want to implement some template parameters such as volume name/snapshot name (similar to how it works for SC-based tags)

/remove-hold `CreateSnapshotRequest` does not contain information about the PVC/PV other than the volume ID so none of the existing parameters can be used, so this PR is ready for review.